Add support for 4232HA #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newAM
approved these changes
Aug 17, 2024
Thanks for this! I'll give this one last squash.
Please and thank you, although up to you to decide if you wanted to wait for the full implementation with the EEPROM stuff, but again I think that's something upstream that might take some time to look at. FWIW I tested this on hardware and everything seems to work. |
Co-authored-by: Alex Martens <alex@thinglab.org>
newAM
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few typos along the way as well. Fixes #76
Note: This does not add EEPROM support as there appears to be some missing types in the ffi crate, perhaps it needs a bump?