Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split getRepoConfig into readRepoConfig{,OrDefault} #650

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jul 2, 2019

This will be useful for #592
where we only want to cache actual RepoConfigs and not also the default
values.

This will be useful for #592
where we only want to cache actual `RepoConfig`s and not also the default
values.
@fthomas fthomas added this to the 0.3.0 milestone Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #650 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #650      +/-   ##
=========================================
+ Coverage   60.15%   60.2%   +0.04%     
=========================================
  Files          66      66              
  Lines         876     877       +1     
  Branches       17      19       +2     
=========================================
+ Hits          527     528       +1     
  Misses        349     349
Impacted Files Coverage Δ
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0% <0%> (ø) ⬆️
.../org/scalasteward/core/repoconfig/RepoConfig.scala 100% <100%> (ø) ⬆️
...g/scalasteward/core/repoconfig/RepoConfigAlg.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b3a75...f90a396. Read the comment docs.

@fthomas fthomas merged commit d288b9e into master Jul 2, 2019
@fthomas fthomas deleted the topic/readRepoConfigOrDefault branch July 2, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant