Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache RepositoryConfig in DependencyService #592

Closed
fthomas opened this issue Jun 19, 2019 · 1 comment
Closed

Cache RepositoryConfig in DependencyService #592

fthomas opened this issue Jun 19, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@fthomas
Copy link
Member

fthomas commented Jun 19, 2019

We should cache a repos RepositoryConfig when we're caching the libraryDependencies in the DependencyService so that we can ignore dependencies in UpdateService that are ignored in the config.
@fthomas fthomas added the enhancement New feature or request label Jun 19, 2019
fthomas added a commit that referenced this issue Jul 2, 2019
@fthomas
Split getRepoConfig into readRepoConfig{,OrDefault}
f90a396 
This will be useful for #592
where we only want to cache actual `RepoConfig`s and not also the default
values.
@fthomas fthomas mentioned this issue Jul 2, 2019
Merged
@fthomas
Copy link
Member Author

fthomas commented Oct 3, 2019

Closing, since this has been implemented in #692.

@fthomas fthomas closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fthomas