Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DependencyService to RepoCacheAlg and store sbt versions #692

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jul 11, 2019

Storing the sbt versions will be useful later to determine which repos
use an outdated sbt version.

Storing the sbt versions will be useful later to determine which repos
use an outdated sbt version.
@fthomas fthomas added the enhancement New feature or request label Jul 11, 2019
@fthomas fthomas added this to the 0.4.0 milestone Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #692 into master will decrease coverage by <.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   61.03%   61.02%   -0.01%     
==========================================
  Files          78       79       +1     
  Lines        1065     1070       +5     
  Branches       22       24       +2     
==========================================
+ Hits          650      653       +3     
- Misses        415      417       +2
Impacted Files Coverage Δ
.../scala/org/scalasteward/core/update/splitter.scala 0% <ø> (ø) ⬆️
...la/org/scalasteward/core/application/Context.scala 0% <ø> (ø) ⬆️
.../main/scala/org/scalasteward/core/sbt/SbtAlg.scala 71.18% <ø> (ø) ⬆️
...g/scalasteward/core/repocache/json/RepoStore.scala 0% <ø> (ø)
...la/org/scalasteward/core/repocache/RepoCache.scala 0% <ø> (ø)
...scalasteward/core/sbt/data/ArtificialProject.scala 100% <ø> (ø) ⬆️
.../main/scala/org/scalasteward/core/sbt/parser.scala 100% <ø> (ø) ⬆️
...teward/core/nurture/json/JsonPullRequestRepo.scala 0% <ø> (ø) ⬆️
...scala/org/scalasteward/core/model/Dependency.scala 75% <ø> (ø)
...a/org/scalasteward/core/update/UpdateService.scala 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a88d3...604e4f4. Read the comment docs.

@fthomas
Copy link
Member Author

fthomas commented Jul 11, 2019

The second commit also caches RepoConfigs so that we can exclude ignored updates in the update check in UpdateService.

@fthomas fthomas merged commit 3bdadce into master Jul 11, 2019
@fthomas fthomas deleted the topic/repocache branch July 11, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant