This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to opt-in to FastClick for elements matching a specified query selector. Instead of using
.needsclick
everywhere, FastClick can now apply itself only to elements matching.fastclick
, for example:I was previously using SelectiveFastclick to handle this, but it was causing some problems with scrolling on iOS, and it didn't make much sense to me to have the overhead of an entirely separate project for what should be a small feature.
Here are some GitHub issues that this may address:
Unfortunately, browser support for this is a bit more limited than FastClick, itself, so I've noted that in the README. This may be a deal-breaker (it wasn't for me), so hopefully this PR is at least helpful to someone even if it's not fully ready to merge.