fix: pre commit hooks broken #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
requested changes
Aug 29, 2023
package.json
Outdated
| @@ -6,7 +6,8 @@ | |||
| "test": "vitest --run test && yarn lint", | |||
| "build": "vite build", | |||
| "prepack": "yarn build", | |||
| "prepublish": "yarn test" | |||
| "prepublish": "yarn test", | |||
| "postinstall": "husky install" | |||
There was a problem hiding this comment.
i don't think this is compatible for public packages, see: https://typicode.github.io/husky/getting-started.html#yarn-2
There was a problem hiding this comment.
Is is not. I've now added pinst to account for that.
jimmycallin
approved these changes
Aug 29, 2023
|
LGTM too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previous changes to the project accidentally removed the husky pre-commit hooks. This PR restores them.
Test
Try committing something that would be stopped by eslint or fixed by prettier and make sure the appropriate action is taken.