feat(TS): Changed tests to TypeScript and updated typings #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gismya
requested changes
Sep 7, 2023
|
Excellent feedback! I made some changes. |
|
I think everything has been resolved now! 🤞 |
gismya
changed the title
gismya
approved these changes
Sep 11, 2023
gismya
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Changed tests to TypeScript and updated typings. * fix: review changes
gismya
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Changed tests to TypeScript and updated typings. * fix: review changes
gismya
added a commit
that referenced
this pull request
Sep 11, 2023
* fix: publishReply has incorrect Event in reply * Corrected source preparation * Apply suggestions from code review Co-authored-by: Lucas Stålner Correia <lucas.correia@ftrack.com> * PR suggestions * feat(TS): Changed tests to TypeScript and updated typings (#136) * Changed tests to TypeScript and updated typings. * fix: review changes * feat(TS): Changed tests to TypeScript and updated typings (#136) * Changed tests to TypeScript and updated typings. * fix: review changes * Empty-merge * Event dropped out in merges --------- Co-authored-by: Lucas Stålner Correia <lucas.correia@ftrack.com> Co-authored-by: Mathias Lykkegaard Lorenzen <mathias.lykkegaard.lorenzen@lego.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted all tests to TypeScript in this PR.
As part of doing that, I noticed some places where
__entity_type__was not included in the types, and some places where anentity_keywas passed as a string in the tests, but was expecting a string-array. Please double-check these typing changes.There were some cases where a private method was called from a test. This should probably be avoided in the future, but for those cases for now, I added
@ts-ignore.There are also some cases where I defined a type as
anybecause the type was too complex for me to model, but this gets it quite far.