feat: trigger reconnect on emit if not connected #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffMathy
approved these changes
Oct 17, 2023
|
From a code standpoint, looks good to me. Haven't tested it. Nice work. |
jimmycallin
reviewed
Oct 24, 2023
jimmycallin
reviewed
Oct 24, 2023
jimmycallin
reviewed
Oct 24, 2023
| @@ -456,7 +456,7 @@ describe("Tests using SimpleSocketIOClient", () => { | |||
| // Reconnect should not be called yet | |||
| expect(client.attemptReconnect).toHaveBeenCalledTimes(0); | |||
| }); | |||
| test("reconnect method exponentially increase delay for every attempt, stopping at the max value", () => { | |||
There was a problem hiding this comment.
i think it would be helpful with a test that ensures that multiple calls to reconnect during the connection phase does not lead to multiple reconnection attempts in case of failure, just one.
|
This is a very valued change. Thank you! |
jimmycallin
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue that halts reconnection attempts if the failed initialization takes longer than the time to attempt a new reconnection attempt.
Makes the reconnect behavior slightly more aggressive for clients using the WebSocket instance without using the EventServer*.
Took the opportunity to fix some naming inconsistencies.
*Legacy ftrack internal use case, there's no reason to replicate for anyone else
Test
Is there any place this could break anything?