fix: Event server error when event data contains colons #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
reviewed
Nov 20, 2023
jimmycallin
reviewed
Nov 20, 2023
source/simple_socketio.ts
Outdated
| @@ -204,7 +204,8 @@ export default class SimpleSocketIOClient { | |||
| * @private | |||
| */ | |||
| private handleMessage(event: MessageEvent): void { | |||
| const [packetType, data] = event.data.split(/:::?/); | |||
| const packetType = event.data[0]; // Get the first character of the message, the packet type | |||
| const data = event.data.replace(/^\d+:::?/, ""); // Remove the packet type and the : that split message parts. | |||
There was a problem hiding this comment.
nit: no need for + since packetType is always a single digit.
would be nice with a small comment that showcased the message format, explaining that double colons are when data is not set.
jimmycallin
previously approved these changes
Nov 20, 2023
jimmycallin
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The handleMessage methods split the message using the
.split()method, which caused issues when the data contained groups of::. This changes the message parsing to be more explicit.Test
Test messages both with or without ::.