Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decoding objects doesn't work properly from Jest #186

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: decoding objects doesn't work properly from Jest #186

merged 1 commit into from
Dec 8, 2023

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Dec 7, 2023

Fixes #187

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

Test

@ffMathy ffMathy requested a review from a team as a code owner December 7, 2023 12:34
@ffMathy
Copy link
Contributor Author

ffMathy commented Dec 7, 2023

@gismya any idea why the build is failing?

@gismya
Copy link
Contributor

gismya commented Dec 8, 2023

I tried really hard to find a reason why this would cause any issues, but it seems like a fine change. It's very weird that Jest has issues with this, but when searching around I find a few examples of it.

@gismya gismya merged commit f2f4d5d into ftrackhq:main Dec 8, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gismya gismya gismya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: dates are wrong type in Jest
2 participants
@ffMathy @gismya