chore: Make ws dependency optional for node.js environments #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
commented
Mar 11, 2025
| @@ -27,8 +27,7 @@ class MockXmlHttpRequest extends EventTarget { | |||
| } | |||
|
|
|||
| beforeAll(() => { | |||
| server.listen({ onUnhandledRequest: "bypass" }); | |||
| global.fetch = fetch; | |||
There was a problem hiding this comment.
leftovers from when we removed cross-fetch
jimmycallin
commented
Mar 11, 2025
| @@ -27,8 +27,7 @@ class MockXmlHttpRequest extends EventTarget { | |||
| } | |||
|
|
|||
| beforeAll(() => { | |||
| server.listen({ onUnhandledRequest: "bypass" }); | |||
| global.fetch = fetch; | |||
| server.listen({ onUnhandledRequest: "error" }); | |||
There was a problem hiding this comment.
now when websocket updates are handled natively, we can do "error" again 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As Node >= 21 has a built-in websocket client, it's preferable to not having to rely on the
wsdependency throughisomorphic-wsfor Node, but rather check if WebSocket is available in the global namespace, and only loadwsif not.Once Node 20 becomes EOL (2026-04-30) we can remove ws as well and only rely on undici's WebSocket.
Test