Skip to content

chore: Add permissions type to session #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

chore: Add permissions type to session #320

merged 1 commit into from
Oct 8, 2025

Conversation

swetapadmanabhan
Copy link
Contributor

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

  • Add permissions type to user_information of session.

Test

  • Check if the types align with the backend

@swetapadmanabhan swetapadmanabhan self-assigned this Oct 8, 2025
@swetapadmanabhan swetapadmanabhan requested a review from a team as a code owner October 8, 2025 08:35
@swetapadmanabhan swetapadmanabhan requested review from nemanjab17 and octavian-ionescu and removed request for a team October 8, 2025 08:35
octavian-ionescu
octavian-ionescu approved these changes Oct 8, 2025
View reviewed changes
Copy link

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@swetapadmanabhan swetapadmanabhan merged commit d9a9b7d into main Oct 8, 2025
3 checks passed
@swetapadmanabhan swetapadmanabhan deleted the add-permissions-type-to-session branch October 8, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octavian-ionescu octavian-ionescu octavian-ionescu approved these changes

@nemanjab17 nemanjab17 Awaiting requested review from nemanjab17

Assignees

@swetapadmanabhan swetapadmanabhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swetapadmanabhan @octavian-ionescu