feat: Typescript 5/4 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaylonFtrack
reviewed
Feb 8, 2023
gismya
reviewed
Feb 8, 2023
| @@ -81,7 +72,7 @@ export type Operation = | |||
| * @param {Object} data Entity data to use for creation | |||
| * @return {Object} API operation | |||
| */ | |||
| export function createOperation(type: string, data: any): CreateOperation { | |||
| export function create(type: string, data: any): CreateOperation { | |||
There was a problem hiding this comment.
Even though they probably are not ment to be used outside this project, must we not wait with changing function names until it's time to make a major version release?
There was a problem hiding this comment.
they were not exposed publicly from index.ts, so only way to have used them would be if someone imported them directly from @ftrack/api/dist/operation, which I don't think is supported behavior. The function names reflect their names in the now removed default object.
There was a problem hiding this comment.
I think I'm just overly cautious.
gismya
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Additional fixes and enhancements from trying out the beta.
Test