feat: Added response types for different actions #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
requested changes
Mar 1, 2023
jimmycallin
reviewed
Mar 1, 2023
jimmycallin
reviewed
Mar 1, 2023
Co-authored-by: Jimmy Callin <jimmy.callin@ftrack.com>
jimmycallin
reviewed
Mar 1, 2023
source/types.ts
Outdated
| __entity_type__: string; | ||
| } | ||
| interface ResponseMetadata { | ||
| metadata: { |
There was a problem hiding this comment.
remove the metadata wrapper here
jimmycallin
approved these changes
Mar 2, 2023
gismya
added a commit
that referenced
this pull request
May 15, 2023
* Added types for all action responses and general type improvements * More precise return type for createComponent * Added generic types to ensure, query, search, create, update and createComponent --------- Co-authored-by: Jimmy Callin <jimmy.callin@ftrack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added types for the different kinds of responses, based on what action the call sends.
Test
Make sure the types are correct, especially for CreateResponse, UpdateResponse, and DeleteResponse, which differ from the older Response type.