Skip to content

chore: Update documentation build to use poetry / python 3.10 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

chore: Update documentation build to use poetry / python 3.10 #36

merged 1 commit into from
Mar 18, 2024

Conversation

torsdag
Copy link
Contributor

@torsdag torsdag commented Mar 18, 2024

Resolves

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains updates to the release notes.
  • I have verified that the documentation is still up to date.

Changes

  • use poetry for dependency resolution when building documentation.
  • use python 3.10 when building documentation.
  • make sphinx and sphinx_rtd_theme development dependencies.

Test

https://ftrack-python-api.readthedocs.io/en/backlog-readthedocs-python-version/

@torsdag torsdag requested a review from a team as a code owner March 18, 2024 10:27
octavian-ionescu
octavian-ionescu approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

octavian-ionescu
octavian-ionescu reviewed Mar 18, 2024
View reviewed changes
readthedocs.yaml
os: ubuntu-22.04
tools:
python: "3.7"
python: "3.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we only go up to 3.10 and not 3.12?

@torsdag torsdag merged commit 84019bc into main Mar 18, 2024
@torsdag torsdag deleted the backlog/readthedocs-python-version branch March 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavian-ionescu octavian-ionescu octavian-ionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torsdag @octavian-ionescu