Fix slurp not always taking shortest path #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu5ha
requested changes
Dec 26, 2022
Right, Rotor3 is Copy, didn't think about that Co-authored-by: Gray Olson <gray@grayolson.com>
|
Sure, that definitely looks better |
fu5ha
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #152. As discussed in this issue and explained here, most 3d engines (and model exporters) expect slerp between two quaternions (rotors in this case) to always take shortest path, despite dot product's sign.
Fixes an issue when interpolating between keyframes of animated models.