dxvk,vkd3d-proton: fix #86
Conversation
|
Do the archives not contain the submodules? I think that's an issue upstream needs to fix. I also made an issue in npins that would make it easier for us to use artifacts from releases: andir/npins#44. In the meantime, unless someone updates these packages manually, we'd need an update script similar to the |
|
The pins are using a tarball of the commit at the release generated by github which doesn't include submodules and I don't think the upstream project can change that. |
LunNova
force-pushed
the
vkd3d-dxvk-fix
branch
from
4928c8a
to
0bdbef6
Compare
|
This PR is now using npins at this PR: andir/npins#46 and can't be merged until that becomes part of an npins release |
|
@LunNova while we're waiting on the merge of that PR, the dxvk derivation remains broken. I propose using npins from that branch, by including it in a devShell in this flake. |
@fufexan would you be okay taking over this PR and doing that part yourself? Changing the update process for your flake feels like I'm likely to do things in ways you didn't intend and need back/forth reviewing. Otherwise I can give it a shot when I have time |
|
Okay, I'll handle that. But first I want to ask the PR author whether it's going to be merged soon. |
|
@LunNova andir/npins#46 has been merged. Do you intend to continue working on this PR? |
Fixes #85
This gets them working again but isn't using npins any more.