Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

props_ordered does not work for nested fields #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdefauw
Copy link

@sdefauw sdefauw commented Dec 16, 2020

Fix for the issue described #109

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 711981a on sdefauw:master into becfa24 on fuhrysteve:master.

@fuhrysteve
Copy link
Owner

Looks like the only thing holding this one back is black formatting: https://travis-ci.org/github/fuhrysteve/marshmallow-jsonschema/jobs/749987034

@sdefauw
Copy link
Author

sdefauw commented Jun 15, 2022

I should be okay now

@sdefauw
Copy link
Author

sdefauw commented Aug 2, 2022

@fuhrysteve Can you look if all is okay for you now ?

@Quasarman
Copy link

Facing the same issue, can we merge this change by any chance? Would be great since this is a awesome package.

@sdefauw
Copy link
Author

sdefauw commented Nov 7, 2023

@fuhrysteve What is missing in order to validate the pull request?

@sdefauw
Copy link
Author

sdefauw commented Apr 17, 2024

@fuhrysteve Can we have some new about this merge request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants