-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metadata on custom fields. #21
base: master
Are you sure you want to change the base?
Conversation
Sorry I didn't notice this before. I like this functionality - I think even better than the For example, this would not work:
What if we dropped the whole
When I originally made the
Let me know what you think or if I missed anything! |
bump. I really like this, and I think I'd need it to be able to integrate this library into my project |
Hi @fuhrysteve @eligundry , could you please clarify what's the status of this PR? I wouldn't mind implementing any of the corrections needed myself to get this into master. |
If I'm not mistaken, you should be able to get this functionality by implementing To help me understand what we're working towards here, would you mind showing an example of what the API change would be (from a high level) so it's clear why this is an improvement on what already exists today? |
Is this just a way to make it so that you don't have to implement your own type in order to inject stuff into |
Custom fields now can have titles and stuff!