-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for marshmallow Regexp validator #24
base: master
Are you sure you want to change the base?
Conversation
2 similar comments
Hi, thank you for maintaining marshmallow-jsonschema! Are there any plans to accept this Pull request? Just came across the need to have that, started to write a handler and then saw this pull request... |
Thanks for the bump, @dim0x69 I'm wondering if the regex syntax is the same between python and jsonschema? Does that matter here?
The python docs seem... unclear about whether they're using a specific / standard syntax?
I'm inclined to merge this as is with the hopes that most common use cases won't run into any meaningful discrepancies, however if you happen to have any insights on the above I'd love to hear |
@fuhrysteve, I'm not sure how accuracte/comprehensive this page is, but it seems to indicate the Regular Expressions in Python have quite a few more features than those in JavaScript (the ECMAScript specification in particular). This would mean that there should be few issues with Python evaluating regular expressions defined in a JSON Schema since JSON Schema specifies the syntax/features of regex as defined in ECMAScript 262. |
Ah so they're at least compatible to a reasonable extent. That makes sense. I created a pull request attempting to merge conflicts, but looks like there are some upstream changes that make the test fail. I can take a look later on! |
No description provided.