Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Test with setup.py #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ecarreras
Copy link
Contributor

@ecarreras ecarreras commented May 29, 2018

Now is possible to run python setup.py test and tests
are executed

Now is possible to run python setup.py test and tests
are executed
@coveralls
Copy link

coveralls commented May 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 4d67738 on gisce:better_test_integration into f6c2dae on fuhrysteve:master.

@fuhrysteve
Copy link
Owner

Any reason putting all the tests in a class BaseTest?

Thanks for the pull!!

@ecarreras
Copy link
Contributor Author

@fuhrysteve the reason is to follow the standard that all the tests are inside a Testcase class.

It wasn't required beacuse you use the py.test runner, but the standard lib unittest is the way to go.

Then it allow to reduce code usint the setUp and teardDown for each tests or setUpclass or teadDownclass for all the tests in that Test Case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants