-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip title if either fields are None #93
base: master
Are you sure you want to change the base?
Conversation
2cc2ef8
to
72234a2
Compare
The build is failing because After a new version is released, the build is supposed to pass. |
72234a2
to
01d42ac
Compare
Hmmm even after a new release, the build is still failing... I also added an extra test case, but the coveralls are still -1.8% :( |
Hi @yeralin! The build is failing because of a subtle bug that was introduced in previous PRs. See #102 for details. I'm afraid that we'll have to wait until that PR fixes master, and only then you can rebase your branch and have clean builds. I think that your solution works just fine: it maintains backward compatibility and in my opinion we will need to drop Python 2 support and Marshmallow 2 support very soon anyway. |
01d42ac
to
dcf4b47
Compare
Addresses #87
Because of lack of support of doubly (or more) nested schemas, some
title
s get rendered asnull
which breaks JSON schema validation. This PR simply skipstitle
iffield.attribute
orfield.name
areNone