Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance router usability #124

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Enhance router usability #124

merged 2 commits into from
Jul 22, 2024

Conversation

LeStegii
Copy link
Collaborator

This PR refactors the router to make it more usable and allow for some more functionality.

General

  • Use providers instead of provider fields (internal)
  • Add methods for checking if routes exist: routesRegistered() and containsRoute()
  • Rename methods: getController() -> getRoute()
  • Allow registration of additional routes at a later time
  • Remove custom exceptions

Closes #122

This PR has breaking API changes.

LeStegii and others added 2 commits July 22, 2024 12:27
@LeStegii
refactor(framework): Enhance router usability
b34e50b 
- Use providers instead of provider fields
- Add methods for checking if routes exist
- Rename methods
@LeStegii @github-actions
docs: Update ERROR_CODES.md
5032a97
@LeStegii LeStegii requested a review from Clashsoft July 22, 2024 10:30
@LeStegii LeStegii merged commit 35debb4 into master Jul 22, 2024
4 checks passed
@LeStegii LeStegii deleted the refactor/router branch July 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clashsoft Clashsoft Clashsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router is hard to use
2 participants
@LeStegii @Clashsoft