Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.exit from FulibFxApp.stop #97

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion framework/src/main/java/org/fulib/fx/FulibFxApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ public void start(Stage primaryStage) {
public void stop() {
cleanup();
autoRefresher().close();
System.exit(0);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
public class ControllerTest extends ApplicationTest {

@Spy
public final MyApp app = new MyApp();
protected MyApp app = new MyApp();

protected Stage stage;

Expand All @@ -18,4 +18,12 @@ public void start(Stage stage) throws Exception {
stage.requestFocus();
app.start(stage);
}

@Override
public void stop() throws Exception {
super.stop();
app.stop();
app = null;
stage = null;
}
}
10 changes: 9 additions & 1 deletion ludo/src/test/java/de/uniks/ludo/ControllerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
public class ControllerTest extends ApplicationTest {

@Spy
public final App app = new App();
protected App app = new App();

protected Stage stage;

Expand All @@ -18,4 +18,12 @@ public void start(Stage stage) throws Exception {
stage.requestFocus();
app.start(stage);
}

@Override
public void stop() throws Exception {
super.stop();
app.stop();
app = null;
stage = null;
}
}