Windows application verifier errors #1443
Comments
fujiapple852
changed the title
|
All issues appear to related to closing the socket twice. The original Windows // Interestingly, Socket2 sockets don't seem to call closesocket on drop??
#[instrument(skip(self))]
fn close(&mut self) -> IoResult<()> {
syscall!(closesocket(self.inner.as_raw_socket() as _), |res| res
== SOCKET_ERROR)
.map_err(|err| IoError::Other(err, IoOperation::Close))
.map(|_| ())
}However, the #[stable(feature = "io_safety", since = "1.63.0")]
impl Drop for OwnedSocket {
#[inline]
fn drop(&mut self) {
unsafe {
let _ = sys::c::closesocket(self.socket as sys::c::SOCKET);
}
}
}This leads to a double impl Drop for SocketImpl {
fn drop(&mut self) {
self.close().unwrap_or_default();
if self.ol.hEvent != -1 && self.ol.hEvent != 0 {
syscall!(WSACloseEvent(self.ol.hEvent), |res| { res == 0 }).unwrap_or_default();
}
}
}Note that #386 introduced a call to The fix is to remove |
|
@zarkdav just FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
trip.exeon Windows 11 VM with Application VerifierThe following 3 issues were observed.
Issue 1:
trip 1.1.1.1This test
icmpand auto-discovers the src IP address.Fails with
Attempt to use a closed SOCKETfromtrippy_core::net::platform::windows::routing_interface_query, which is called at startup to auto-discover the src IP address.Re-running the above without the
Networkinglayer, the failure is:Issue 2:
trip 1.1.1.1 -A 10.0.2.15This test
icmpand validate the provided src IP address.Fails with
Attempt to use a closed SOCKETfromtrippy_core::net::source::SourceAddr::validatewhich is called at startup to validate the provided IP address.Re-running the above without the
Networkinglayer, the failure is:Issue 3:
trip 1.1.1.1 --tcpSimilar issues.
The text was updated successfully, but these errors were encountered: