Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Adjusted Gemfile for jruby (optional) #114

Closed
wants to merge 3 commits into from

Conversation

DrTom
Copy link

@DrTom DrTom commented May 30, 2012

all specs green,
tested with jruby 1.6.7 in 1.9 compat mode, and with postgresql 9.1

  all specs green,
  tested with jruby 1.6.7 in 1.9 compat mode, and with postgresql 9.1
@malclocke
Copy link

Could you add a jruby target to ~/.travis.yml and add your fork to travis to ensure all the builds are green?

@DrTom
Copy link
Author

DrTom commented May 31, 2012

So I did. It fails on travis but I can't reproduce that on my machine. It seems to be a timing issue with capybar/webdriver. It will pass if we insert sleep 5 before line 33 and 35 of spec/requests/stories_spec.rb. I haven't kept that change in the repro for the time being.

@malclocke
Copy link

Ok, cool. Yes, that spec has been failing intermittently on the other builds too.

So, the problem I have with this is the same as a previous pull request on the same topic (#105), in that when I run bundle on MRI 1.9.2 I get a diff on Gemfile.lock. In this case its removing pry. Any ideas?

@DrTom
Copy link
Author

DrTom commented Jun 1, 2012

Yes, I used pry temporarily. It seems that I removed it from the Gemfile but did not bundle afterwards so it was left over in the Gemfile.lock. This is fixed with the last commit: DrTom@5e14b39.

@parndt
Copy link
Contributor

parndt commented Nov 29, 2012

Either this, or #105, should be merged so that both can be dealt with :-)

@sanemat
Copy link
Contributor

sanemat commented Jan 5, 2013

👍

kaleworsley added a commit to kaleworsley/fulcrum that referenced this pull request Apr 20, 2013
@malclocke
Copy link

Closing as duplicate of #105

@malclocke malclocke closed this Jan 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants