Fix GHA workflow for multi-platform builds #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdidion
added
bug
nh13
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original commit of this workflow didn't work. I've updated it with the correct configuration. It now succeeds:
https://github.com/fulcrumgenomics/pybedlite/actions/runs/6162641801
The only remaining issue is how to tie this into the publishing process. The result of this workflow is an archive of all the wheels attached to the build, so it will require the person doing the release to download the archive, unpack it and either 1) move all the wheels into the
distfolder and hope that poetry will just upload everything there that has the correct version, or b) manually upload the wheels to the release on pypi after publishing.It would also be possible to automate the entire release process (e.g. using https://github.com/marketplace/actions/pypi-publish).
Side note - it looks like aarch64 linux nodes are in short supply - those build jobs take a long time.