fix(CTC-135): do not create order with empty tags array

fulfillmenttools · May 3, 2024 · b783dd0 · b783dd0
1 parent 037c416
commit b783dd0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/event/src/order/orderMapper.ts b/event/src/order/orderMapper.ts
@@ -19,7 +19,7 @@ export class OrderMapper {
 
   public async mapOrder(commercetoolsOrder: CommercetoolsOrder): Promise<FulfillmenttoolsOrder> {
     const configuration = await getConfiguration();
-    return {
+    const order: FulfillmenttoolsOrder = {
       tenantOrderId: commercetoolsOrder.orderNumber || commercetoolsOrder.id,
       consumer: this.mapConsumer(commercetoolsOrder),
       orderDate: new Date(commercetoolsOrder.createdAt),
@@ -31,8 +31,12 @@ export class OrderMapper {
       paymentInfo: {
         currency: commercetoolsOrder.totalPrice.currencyCode,
       },
-      tags: this.mapTags(commercetoolsOrder, configuration),
     };
+    const tags = this.mapTags(commercetoolsOrder, configuration);
+    if (tags && tags.length > 0) {
+      order.tags = tags;
+    }
+    return order;
   }
 
   private async getPreselectedFacilities(commercetoolsOrder: CommercetoolsOrder): Promise<PreselectedFacility[]> {

diff --git a/event/tests/orderMapper.test.ts b/event/tests/orderMapper.test.ts
@@ -54,6 +54,7 @@ describe('OrderMapper', () => {
     expect(article.title).toEqual('Cigköfte Wrap');
     expect(article.imageUrl).toEqual('https://fancy-image.example.com');
     expect(fulfillmenttoolsOrder.tenantOrderId).toEqual('orderNumber');
+    expect(fulfillmenttoolsOrder.tags).toBeUndefined();
   });
 
   it('defaults to id if orderNumber is undefined', async () => {