Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue 2.x to vue 3.x #148

Closed
wants to merge 2 commits into from
Closed

Conversation

marvelbark2
Copy link
Contributor

Updating vue APi with the new APIs

Updating vue APi with the new APIs
@@ -12,16 +12,16 @@ interface FullCalendarInternal {
}


const FullCalendar = Vue.extend({
const FullCalendar = Vue.extend{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vue.extend suppose to be deleted because its replaced by defineComponent

@acerix
Copy link
Member

acerix commented Feb 22, 2021

Thanks, this fixes #131 ?

@arshaw arshaw added this to the upcoming-release milestone Feb 22, 2021
@jippeholwerda
Copy link

I would expect the version of Vue to be updated in package.json as well?

@marvelbark2
Copy link
Contributor Author

You will use a vue 3 so that mean you should update your fullcalendar vue sdk

@aliasaria
Copy link

This doesn't build for me:
npm run build

results in:

> tsc -p tsconfig.json && rollup -c && npm run minify

src/FullCalendar.ts:15:32 - error TS1005: ',' expected.

15 const FullCalendar = Vue.extend{
                                  ~

src/FullCalendar.ts:18:21 - error TS1005: ',' expected.

18     options: Object as PropType<CalendarOptions>
                       ~~

src/FullCalendar.ts:18:24 - error TS1005: ',' expected.
...

@marvelbark2
Copy link
Contributor Author

Vue.extend

Hey , You should delete
Vue.extend on const FullCalendar = ...

@aliasaria
Copy link

@marvelbark2 do you mean you can get npm run build to build this project? Removing this doesn't fix the build. I am just building a plain copy of your code:

https://github.com/marvelbark2/fullcalendar-vue/blob/patch-2/src/FullCalendar.ts

@marvelbark2
Copy link
Contributor Author

@aliasaria I fixed the issue !

@arshaw
Copy link
Member

arshaw commented Mar 24, 2021

note to self: releasing this will break compatibility with Vue 2. release this as a version like 5.1.2-vue3, then have a dist-tag called vue3 that makes npm-installing more convenient.

any input on a better release strategy is welcome

@potraike
Copy link

Hi, do you have any plans when this release will be available?

@guifischer
Copy link

Any chance to get a vue 3 "beta" branch with this changes?

@arshaw
Copy link
Member

arshaw commented Jun 2, 2021

I've merged this into the vue3 branch and released it as the @fullcalendar/vue3 package!

@arshaw arshaw closed this Jun 2, 2021
@arshaw
Copy link
Member

arshaw commented Jun 2, 2021

(it required quite a bit more work), but thanks so much for helping me get started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants