-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue 2.x to vue 3.x #148
vue 2.x to vue 3.x #148
Conversation
Updating vue APi with the new APIs
src/FullCalendar.ts
Outdated
@@ -12,16 +12,16 @@ interface FullCalendarInternal { | |||
} | |||
|
|||
|
|||
const FullCalendar = Vue.extend({ | |||
const FullCalendar = Vue.extend{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vue.extend suppose to be deleted because its replaced by defineComponent
Thanks, this fixes #131 ? |
I would expect the version of Vue to be updated in |
You will use a vue 3 so that mean you should update your fullcalendar vue sdk |
This doesn't build for me: results in: > tsc -p tsconfig.json && rollup -c && npm run minify
src/FullCalendar.ts:15:32 - error TS1005: ',' expected.
15 const FullCalendar = Vue.extend{
~
src/FullCalendar.ts:18:21 - error TS1005: ',' expected.
18 options: Object as PropType<CalendarOptions>
~~
src/FullCalendar.ts:18:24 - error TS1005: ',' expected.
... |
Hey , You should delete |
@marvelbark2 do you mean you can get https://github.com/marvelbark2/fullcalendar-vue/blob/patch-2/src/FullCalendar.ts |
@aliasaria I fixed the issue ! |
note to self: releasing this will break compatibility with Vue 2. release this as a version like any input on a better release strategy is welcome |
Hi, do you have any plans when this release will be available? |
Any chance to get a vue 3 "beta" branch with this changes? |
I've merged this into the |
(it required quite a bit more work), but thanks so much for helping me get started! |
Updating vue APi with the new APIs