Adding write compliant proto parquet support, but from new library 1.… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…12.x, and upgrading for empty collection / required/optional support
|
🤦 Unfortunately committed a maven credential -- since been revoked and generated new one for use locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of discussion around parquet file formats -- want something writeCompliant, and that can be read by scala pb case classes -- which require collections to be empty, not null to avoid NPEs in Spark.
@kerdosa added the ability to write empty collections in the ArrayWriter -- so spark can read them from ScalaPB Case classes.
Note: Ignore all Legacy* commit, they are not used kafka-2.0.0 profile.