Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error handling for critical errors after subscription charge #156

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

vegu
Copy link
Contributor

@vegu vegu commented Feb 1, 2024

No description provided.

@vegu vegu requested a review from grizz February 1, 2024 15:46
@vegu vegu changed the base branch from 20240131-django4 to prep-release February 1, 2024 16:12
@vegu vegu force-pushed the fc-1575-billing-tests branch from 4af7bb0 to f3d990c Compare February 1, 2024 16:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5a73a26) 71.19% compared to head (f3d990c) 71.82%.

Files Patch % Lines
src/billing/management/commands/billing_cycles.py 97.29% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           prep-release     #156      +/-   ##
================================================
+ Coverage         71.19%   71.82%   +0.63%     
================================================
  Files               132      133       +1     
  Lines              2232     2268      +36     
================================================
+ Hits               1589     1629      +40     
+ Misses              643      639       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegu vegu merged commit e401af7 into prep-release Feb 1, 2024
vegu added a commit that referenced this pull request Feb 12, 2024
* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* add jwt authentication

* fix token authentication errors

* formatting

* add docs

---------

Co-authored-by: Stefan Pratter <stefan@20c.com>
vegu added a commit that referenced this pull request Feb 14, 2024
* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* add jwt authentication

* fix token authentication errors

* formatting

* add docs

---------

Co-authored-by: Stefan Pratter <stefan@20c.com>
grizz added a commit that referenced this pull request Apr 17, 2024
* poetry lock

* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* poetry lock

* Version 1.3.1-rc.1

* Version 1.3.1-rc.2

* Version 1.4.0-rc.1

* Version 1.4.0-rc.2

* move django-cors-headers to fullctl (#160)

* remove django-cors-headers

* relock poetry

* relock

* add autocomplete fields for admin (#159)

* poetry lock

* Version 1.4.0-rc.3

* poetry lock

* poetry lock

* Version 1.4.0-rc.4

* FC-2801 billing task (#165)

* dedicated billing cycle task

* actually, probably dont want to log this as it might contain sensitive data

* disable org deletion through django-admin (#166)

* poetry lock

* Version 1.4.0-rc.5

* poetry lock

* Version 1.4.0-rc.6

* relock

* poetry lock

* Version 1.4.0-rc.7

* poetry lock

* Version 1.4.0-rc.8

* Version 1.4.0-rc.9

* Version 1.4.0-rc.10

* Version 1.4.0-rc.11

* Version 1.4.0

---------

Co-authored-by: Jason Mishike <98209208+jason20c@users.noreply.github.com>
Co-authored-by: Stefan Pratter <stefan@20c.com>
grizz added a commit that referenced this pull request Apr 18, 2024
* poetry lock

* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* Add JWT authentication (#152)

* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* add jwt authentication

* fix token authentication errors

* formatting

* add docs

---------

Co-authored-by: Stefan Pratter <stefan@20c.com>

* poetry lock

* Version 1.3.1-rc.1

* Version 1.3.1-rc.2

* Version 1.4.0-rc.1

* Version 1.4.0-rc.2

* move django-cors-headers to fullctl (#160)

* remove django-cors-headers

* relock poetry

* relock

* relock

* add autocomplete fields for admin (#159)

* poetry lock

* Version 1.4.0-rc.3

* poetry lock

* poetry lock

* Version 1.4.0-rc.4

* Add vue frontend auth through url (#164)

* add vue frontend auth through url

* formatting

* add tests

* fix: remove debug messages

* FC-2801 billing task (#165)

* dedicated billing cycle task

* actually, probably dont want to log this as it might contain sensitive data

* disable org deletion through django-admin (#166)

* poetry lock

* Version 1.4.0-rc.5

* poetry lock

* Version 1.4.0-rc.6

* relock

* poetry lock

* Version 1.4.0-rc.7

* relock

* relock

---------

Co-authored-by: Matt Griswold <grizz@20c.com>
Co-authored-by: Jason Mishike <98209208+jason20c@users.noreply.github.com>
vegu added a commit that referenced this pull request May 14, 2024
* poetry lock

* Django 4.2 update (#155)

* change unmaintained django-cors-middleware to django-cors-headers

* change for django-recaptcah updates

* change removed ugettext_lazy to gettext_lazy

* fix for django update

* add django-cors-headers  minimum version

* better error handling for critical errors after subscription charge (#156)

add tests

* poetry lock

* Version 1.3.1-rc.1

* Version 1.3.1-rc.2

* Version 1.4.0-rc.1

* Version 1.4.0-rc.2

* move django-cors-headers to fullctl (#160)

* remove django-cors-headers

* relock poetry

* relock

* add autocomplete fields for admin (#159)

* poetry lock

* Version 1.4.0-rc.3

* org controlled oauth backend implementations

* linting

* relabel section according to specs

* Add frontend for federation (#163)

* add frontend for federation

* change add federated url button styles

* better error message on dupe service
prevent multiple oauths for one org

* rewording

* poetry lock

* poetry lock

* Version 1.4.0-rc.4

* federated service config and service bridge drop in

* linting

* logo url to fed svc support

* account/org services endpoint

* linting

* fix tests

* linting

* FC-2801 billing task (#165)

* dedicated billing cycle task

* actually, probably dont want to log this as it might contain sensitive data

* disable org deletion through django-admin (#166)

* poetry lock

* Version 1.4.0-rc.5

* poetry lock

* Version 1.4.0-rc.6

* relock

* poetry lock

* Version 1.4.0-rc.7

* add role information to org api endpoint

* bump version for federation

* poetry lock

* Version 1.5.0-rc.2

* Version 1.5.0-rc.3

* Version 1.5.0-rc.4

* relock

* fix test data

* fix test data again

---------

Co-authored-by: Matt Griswold <grizz@20c.com>
Co-authored-by: Jason Mishike <98209208+jason20c@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants