Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foobar #23

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Foobar #23

wants to merge 7 commits into from

Conversation

fullofcaffeine
Copy link
Owner

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

…or the zip before posting the message with the link
…ild-plugin-zip workflow finishes running

This is simpler than the polling approach that we used before, but lacks
on flexibility to use further criteria for triggering that's only
available on the `pull_request` event.
…r the build-plugin-zip workflow finishes running"

This reverts commit 6ba9ccd.
…build-plugin-zip workflow

Having it in a separate workflow means tinkering with the Github
dependency API or polling the API to see when the workflow we depend on
finishes. The previous implementation works but is complex and has the
risk of causing throttling if a lot of PRs trigger this polling action.
Copy link

github-actions bot commented Jun 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fullofcaffeine <fullofcaffeine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jun 7, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/blocks.php

@fullofcaffeine fullofcaffeine force-pushed the trunk branch 3 times, most recently from ccde8cc to c7f51bd Compare June 8, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant