fix: production build not working

* build(webpack): update config * docs(readme): update README Closes (#11)
fulls1z3 · Sep 9, 2017 · 4cecdfd · 4cecdfd
1 parent 873de21
commit 4cecdfd
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 45 deletions.
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@
 - Production and development modes.
 - [Webpack DLL]s to speed up development builds.
 - [AoT compilation] for rapid page loads on production builds (*using [@ngtools/webpack]*).
-- Tree-shaking the production builds with [fulls1z3/webpack].
+- Tree-shaking the production builds with `harmony` branch of [UglifyJs2].
 - Hot Module Replacement with [Webpack] and [webpack-hot-middleware].
 - Both inline and external SCSS compilation.
 - Lazy loading of modules.
@@ -71,7 +71,7 @@ Copyright (c) 2017 [Burak Tasci]
 [Webpack DLL]: https://robertknight.github.io/posts/webpack-dll-plugins
 [AoT compilation]: https://angular.io/docs/ts/latest/cookbook/aot-compiler.html
 [@ngtools/webpack]: https://www.npmjs.com/package/@ngtools/webpack
-[fulls1z3/webpack]: https://github.com/fulls1z3/webpack
+[UglifyJs2]: https://github.com/mishoo/UglifyJS2/tree/harmony
 [webpack-hot-middleware]: https://github.com/glenjamin/webpack-hot-middleware
 [@ngx-config]: https://github.com/ngx-config/core
 [@ngx-cache]: https://github.com/ngx-cache/core

diff --git a/config/webpack.common.prod.js b/config/webpack.common.prod.js
@@ -127,28 +127,28 @@ const browserConfig = {
      *
      * See: https://webpack.github.io/docs/list-of-plugins.html#uglifyjsplugin
      */
-    // new uglifyJsPlugin({
-    //  // beautify: false,
-    //  // mangle: {
-    //  //   screw_ie8: true
-    //  // },
-    //  output: {
-    //    comments: false
-    //  },
-    //  compress: {
-    //    screw_ie8: true,
-    //    warnings: false,
-    //    conditionals: true,
-    //    unused: true,
-    //    comparisons: true,
-    //    sequences: true,
-    //    dead_code: true,
-    //    evaluate: true,
-    //    if_return: true,
-    //    join_vars: true,
-    //    negate_iife: false // we need this for lazy v8
-    //  }
-    // }),
+    new uglifyJsPlugin({
+     // beautify: false,
+     // mangle: {
+     //   screw_ie8: true
+     // },
+     output: {
+       comments: false
+     },
+     compress: {
+       screw_ie8: true,
+       warnings: false,
+       conditionals: true,
+       unused: true,
+       comparisons: true,
+       sequences: true,
+       dead_code: true,
+       evaluate: true,
+       if_return: true,
+       join_vars: true,
+       negate_iife: false // we need this for lazy v8
+     }
+    }),
 
     /**
      * Plugin: CompressionPlugin
@@ -227,26 +227,26 @@ const serverConfig = {
      *
      * See: https://webpack.github.io/docs/list-of-plugins.html#uglifyjsplugin
      */
-    // new uglifyJsPlugin({
-    //   // beautify: false,
-    //   mangle: false, // to ensure process.env still works
-    //   output: {
-    //     comments: false
-    //   },
-    //   compress: {
-    //     screw_ie8: true,
-    //     warnings: false,
-    //     conditionals: true,
-    //     unused: true,
-    //     comparisons: true,
-    //     sequences: true,
-    //     dead_code: true,
-    //     evaluate: true,
-    //     if_return: true,
-    //     join_vars: true,
-    //     negate_iife: false // we need this for lazy v8
-    //   }
-    // })//,
+    new uglifyJsPlugin({
+      // beautify: false,
+      mangle: false, // to ensure process.env still works
+      output: {
+        comments: false
+      },
+      compress: {
+        screw_ie8: true,
+        warnings: false,
+        conditionals: true,
+        unused: true,
+        comparisons: true,
+        sequences: true,
+        dead_code: true,
+        evaluate: true,
+        if_return: true,
+        join_vars: true,
+        negate_iife: false // we need this for lazy v8
+      }
+    })//,
 
     /**
      * Plugin: CompressionPlugin

diff --git a/package.json b/package.json
@@ -86,7 +86,8 @@
     "gulp-exec": "^2.1.3",
     "gulp-tslint": "^8.0.0",
     "gulp-replace": "^0.5.4",
-    "webpack": "fulls1z3/webpack#v2.5.1-harmony",
+    "webpack": "^2.5.1",
+    "uglify-js": "git://github.com/mishoo/UglifyJS2#harmony-v2.8.22",
     "webpack-merge": "^4.1.0",
     "webpack-hot-middleware": "^2.18.0",
     "@ngtools/webpack": "^1.3.1",