Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite #8

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Vite #8

merged 3 commits into from
Feb 13, 2024

Conversation

johannespeltola
Copy link
Contributor

  • Migrate from CRA to Vite
  • Replaced deprecated method ReactDOM.render with ReactDOM.createRoot
  • JS --> JSX components
  • Removed unused dependencies and files

@bambery
Copy link

bambery commented Jan 13, 2024

Running this code throws the following: The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

needs "type": "module" in package.json

@Alkebsi
Copy link

Alkebsi commented Feb 12, 2024

Toke your code as my starting point, by the way!

I was about to work on it un till I saw this PR. Thanks anyway @johannespeltola Prof. @mluukkai should review this PR ASAP! It will help a lot. Just getting the old fills the console with errors.

One thing, though! Is the package.json file updated? Running npm install only installs react! I just copied my old node_modules directory.

@mluukkai mluukkai merged commit 209cb71 into fullstack-hy2020:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants