Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin can delete user(s) #745

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Core/Application/Identity/Users/IUserService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public interface IUserService : ITransientService

Task<string> GetOrCreateFromPrincipalAsync(ClaimsPrincipal principal);
Task<string> CreateAsync(CreateUserRequest request, string origin);
Task UpdateAsync(UpdateUserRequest request, string userId);

Task UpdateAsync(UpdateUserRequest request, string userId, CancellationToken cancellationToken);
Task<string> DeleteAsync(string userId, CancellationToken cancellationToken);
Task<string> ConfirmEmailAsync(string userId, string code, string tenant, CancellationToken cancellationToken);
Task<string> ConfirmPhoneNumberAsync(string userId, string code);

Expand Down
2 changes: 2 additions & 0 deletions src/Core/Application/Identity/Users/UpdateUserRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ namespace FSH.WebApi.Application.Identity.Users;
public class UpdateUserRequest
{
public string Id { get; set; } = default!;
public string? UserName { get; set; }
public string? FirstName { get; set; }
public string? LastName { get; set; }
public string? PhoneNumber { get; set; }
public string? Email { get; set; }
public string? Password { get; set; }
public FileUploadRequest? Image { get; set; }
public bool DeleteCurrentImage { get; set; } = false;
}
8 changes: 8 additions & 0 deletions src/Core/Domain/Identity/ApplicationUserEvents.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,12 @@ public class ApplicationUserUpdatedEvent : ApplicationUserEvent
public ApplicationUserUpdatedEvent(string userId, bool rolesUpdated = false)
: base(userId) =>
RolesUpdated = rolesUpdated;
}

public class ApplicationUserDeletedEvent : ApplicationUserEvent
{
public ApplicationUserDeletedEvent(string userId)
: base(userId)
{
}
}
17 changes: 17 additions & 0 deletions src/Host/Controllers/Identity/UsersController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,23 @@ public Task<UserDetailsDto> GetByIdAsync(string id, CancellationToken cancellati
return _userService.GetAsync(id, cancellationToken);
}

[HttpPut("{id}")]
[MustHavePermission(FSHAction.Update, FSHResource.Users)]
[OpenApiOperation("Update profile details of an user.", "")]
public async Task<ActionResult> UpdateUserAsync(string id, UpdateUserRequest request, CancellationToken cancellationToken)
{
await _userService.UpdateAsync(request, id, cancellationToken);
return Ok();
}

[HttpDelete("{id}")]
[MustHavePermission(FSHAction.Delete, FSHResource.Users)]
[OpenApiOperation("Delete a user.", "")]
public Task<string> DeleteAsync(string id, CancellationToken cancellationToken)
{
return _userService.DeleteAsync(id, cancellationToken);
}

[HttpGet("{id}/roles")]
[MustHavePermission(FSHAction.View, FSHResource.UserRoles)]
[OpenApiOperation("Get a user's roles.", "")]
Expand Down
4 changes: 2 additions & 2 deletions src/Host/Controllers/Personal/PersonalController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ public async Task<ActionResult<UserDetailsDto>> GetProfileAsync(CancellationToke

[HttpPut("profile")]
[OpenApiOperation("Update profile details of currently logged in user.", "")]
public async Task<ActionResult> UpdateProfileAsync(UpdateUserRequest request)
public async Task<ActionResult> UpdateProfileAsync(UpdateUserRequest request, CancellationToken cancellationToken)
{
if (User.GetUserId() is not { } userId || string.IsNullOrEmpty(userId))
{
return Unauthorized();
}

await _userService.UpdateAsync(request, userId);
await _userService.UpdateAsync(request, userId, cancellationToken);
return Ok();
}

Expand Down
15 changes: 13 additions & 2 deletions src/Infrastructure/Identity/UserService.CreateUpdate.cs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public async Task<string> CreateAsync(CreateUserRequest request, string origin)
return string.Join(Environment.NewLine, messages);
}

public async Task UpdateAsync(UpdateUserRequest request, string userId)
public async Task UpdateAsync(UpdateUserRequest request, string userId, CancellationToken cancellationToken)
{
var user = await _userManager.FindByIdAsync(userId);

Expand All @@ -155,7 +155,7 @@ public async Task UpdateAsync(UpdateUserRequest request, string userId)
string currentImage = user.ImageUrl ?? string.Empty;
if (request.Image != null || request.DeleteCurrentImage)
{
user.ImageUrl = await _fileStorage.UploadAsync<ApplicationUser>(request.Image, FileType.Image);
user.ImageUrl = await _fileStorage.UploadAsync<ApplicationUser>(request.Image, FileType.Image, cancellationToken);
if (request.DeleteCurrentImage && !string.IsNullOrEmpty(currentImage))
{
string root = Directory.GetCurrentDirectory();
Expand All @@ -172,6 +172,17 @@ public async Task UpdateAsync(UpdateUserRequest request, string userId)
await _userManager.SetPhoneNumberAsync(user, request.PhoneNumber);
}

if (!string.IsNullOrEmpty(request.Password) && await HasPermissionAsync(user.Id, FSHPermission.NameFor(nameof(FSHAction.Update), nameof(FSHResource.Users)), cancellationToken))
{
string token = await _userManager.GeneratePasswordResetTokenAsync(user);
var changePasswordResult = await _userManager.ResetPasswordAsync(user, token, request.Password);

if (!changePasswordResult.Succeeded)
{
throw new InternalServerException(_t["Change password failed"], changePasswordResult.GetErrors(_t));
}
}

var result = await _userManager.UpdateAsync(user);

await _signInManager.RefreshSignInAsync(user);
Expand Down
38 changes: 38 additions & 0 deletions src/Infrastructure/Identity/UserService.Delete.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
using FSH.WebApi.Application.Common.Exceptions;
using FSH.WebApi.Domain.Identity;

namespace FSH.WebApi.Infrastructure.Identity;

internal partial class UserService
{
public async Task<string> DeleteAsync(string userId, CancellationToken cancellationToken)
{
var user = await _userManager.FindByIdAsync(userId);

_ = user ?? throw new NotFoundException(_t["User Not Found."]);

string currentImage = user.ImageUrl ?? string.Empty;
if (!string.IsNullOrEmpty(currentImage))
{
string root = Directory.GetCurrentDirectory();
_fileStorage.Remove(Path.Combine(root, currentImage));
}

var userRoles = await _userManager.GetRolesAsync(user);
var result = await _userManager.RemoveFromRolesAsync(user, userRoles);

if (!result.Succeeded)
{
throw new InternalServerException(_t["Remove role(s) failed."], result.GetErrors(_t));
}

result = await _userManager.DeleteAsync(user);
if (!result.Succeeded)
{
throw new InternalServerException(_t["Remove user failed."], result.GetErrors(_t));
}

await _events.PublishAsync(new ApplicationUserDeletedEvent(user.Id));
return string.Format(_t["{0} succesfully deleted."], user.UserName);
}
}
4 changes: 4 additions & 0 deletions src/Infrastructure/Infrastructure.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
<PackageReference Include="MimeKit" Version="3.3.0" />
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="6.0.4" />
<PackageReference Include="NSwag.AspNetCore" Version="13.16.1" />
<PackageReference Include="NSwag.CodeGeneration" Version="13.16.1" />
<PackageReference Include="NSwag.CodeGeneration.CSharp" Version="13.16.1" />
<PackageReference Include="NSwag.CodeGeneration.TypeScript" Version="13.16.1" />
<PackageReference Include="NSwag.Generation.WebApi" Version="13.16.1" />
<PackageReference Include="RazorEngineCore" Version="2022.1.2" />
<PackageReference Include="ZymLabs.NSwag.FluentValidation.AspNetCore" Version="0.5.1" />
<PackageReference Include="Oracle.EntityFrameworkCore" Version="6.21.61" />
Expand Down