-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Queries with equalTo() return null #121
Comments
I believe I'm getting this too. Edit: I'm using android |
I believe I fixed it. Please review PR #122 |
I created the PR against the HEAD of master, but I didn't test it there. Maybe there's another issue. I'll have to investigate. Edit: oh! and once again I've just tested it in android. |
Yeah, the |
Not completely sure I understood what you proposed since I'm not familiar with the ios code, but what about changing the equalTo code to conditionally pass the
I guess that way it wouldn't have the trailing ':' due to having an |
Well, it shouldn't actually have a trailing |
Anything I could help with here? Happy to get this forward. Thanks for the effort guys! |
Hey auser (& other contributors), |
This is working in v3 now. I think this can be closed @auser |
@moooji @auser I am still experiencing this bug and it looks like I'm not the only one. #293 cc: @neuberoliveira I'm considering migrating to @Salakar's https://github.com/invertase/react-native-firebase Data filtering is crucial for my application. Is this library still being maintained? There haven't been any updates in months. |
@AndrewHenderson can confirm this works and has also been tested over at my end, I fixed this in v3 firestack (my fork of firestack = v3) originally and works also in my repo as above. |
@Salakar I'm attempting to use your library. However, I'm having issues migrating to your project's API. The docs on your repo seem to be out of date. Since then, I've been troubleshooting signing in with Facebook. Currently, your Facebook sign in method fails silently. // React Native Firestack
// This works.
firebaseApp.auth.signInWithProvider('facebook', data.accessToken, ''); // React Native Firebase
// This does not work.
firebaseApp.auth().signInWithCredential({
provider: 'facebook',
token: data.accessToken,
secret: ''
}); I tried adding the Facebook app secret, but that didn't resolve the issue. |
@AndrewHenderson can you make an issue over at RNFirease please, but; I have taken a look though and can't see any issues with this, which platform isn't this working on? signInWithCredential returns a promise, to get any caught exceptions you'll need a .catch, can i see the full code for this if possible? const credential = firebase.auth().FacebookAuthProvider.credential(data.accessToken);
// firebase.auth().FacebookAuthProvider will soon be moved to
// firebase.auth.FacebookAuthProvider to match the firebase web sdk
firebase.auth().signInWithCredential(credential)
.then(currentUser => {
// now signed in
console.warn(JSON.stringify(currentUser.toJSON()));
})
.catch(error => console.error(error)); |
Hey,
The following code returns
null
, however I do get a correct response using Firebase Web API.Any ideas? Thanks for all the effort, much appreciation here
Edit: Using iOS
The text was updated successfully, but these errors were encountered: