-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Don't hard set play services version #134
Comments
That should be fine. Make a PR when you get a chance. I think that sounds like a great idea. @Ehesp ^^ |
Actually, what do you think about doing this for all Firestack dependencies? |
I supposed the only issue is if the lib isn't kept up to date with say the latest firebase SDK, then users are going to have weird issues. |
Good point. I agree. |
Ehesp
added a commit
to Ehesp/react-native-firestack
that referenced
this issue
Nov 18, 2016
Closing as fixed on v3 branch. |
auser
added a commit
that referenced
this issue
Dec 8, 2016
Don't hard set Android play services version #134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Bear in mind, I'm not to clued up to Android yet...
I keep running into the same issue whereby my build fails due to "Multiple dex files". The cause of this is conflicting play-services versions across multiple libs. This library hard sets the dep to 9.8.0.
Other libs seem to only set it to "whatever is latest", e.g: https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle#L44 & https://github.com/idehub/react-native-google-analytics-bridge/blob/master/android/build.gradle#L21
The only way I can fix these errors is by either:
compile 'com.google.android.gms:play-services-base:+'
.Didn't want to make a PR since I'm not sure if this will have any repercussions?
The text was updated successfully, but these errors were encountered: