V3: orderByChild + startAt or endAt

[florianbepunkt]

@Salakar Sorry to bother you again. It seems like orderByChild is not working, at least when used with startAt or endAt. I have a list of message objects that I want to query based on their timestamp.

This code returns zero results

firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .startAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

while this code returns all results

firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .endAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

Based on my sample data below…both results are wrong. The first example should return the first last two objects, the second example should return the first two objects.

I tried both the v3 branch of this repo as well as master branch of your fork. Based on the sample data the query above should return the first object. But nothing is returned

{
  "-KXlqrDgbJg_-FJCoDfE" : {
    "-KXv8Uvyix9Ns5FeF1O1" : {
      "_id" : "-KXv8Uvyix9Ns5FeF1O1",
      "createdAt" : 1480608580717,
      "text" : "Test123",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvCCjPLePNohIkjSw3" : {
      "_id" : "-KXvCCjPLePNohIkjSw3",
      "createdAt" : 1480609553540,
      "text" : "Test456",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvCDsZq__24IkB6zGs" : {
      "_id" : "-KXvCDsZq__24IkB6zGs",
      "createdAt" : 1480609558242,
      "text" : "Test789",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvQisiS1bsm3oYCdll" : {
      "_id" : "-KXvQisiS1bsm3oYCdll",
      "createdAt" : 1480613359327,
      "text" : "Test101112",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    }
  }
}

[Salakar]

Hmm weird one @florianbepunkt - database in the current pushed up state of my branch has not been touched bar a PR from @BlooJeans which was on master that I manually pulled in.

Will look at this today and get back to you, the example helps, cheers!

[florianbepunkt]

@Salakar Maybe this is of interest #82 – it was not working properly on master until recently

[Salakar]

@florianbepunkt looks like @chrisbianca fixed this issue 3 days ago on my branch - have you tried pulling the latest?

This commit:
Salakar@ec9f488

[florianbepunkt]

@Salakar I did. To make sure I just installed it again via npm install --save https://github.com/Salakar/react-native-firestack.git

The commit only changes things on android side… I see this problem with iOS.

[chrisbianca]

I only updated the Android side as that's where I'd noticed the issue.
Just taken a look and a similar sort of change does need to happen on the iOS side - I'll see if I can take a look in a little while...

[Salakar]

@florianbepunkt oh ok my bad, thought you were having an android issue sorry.

@chrisbianca that would be awesome thanks!

[florianbepunkt]

I'm not sure if this is related… using a fresh install from Salakar's fork I see the same issue on android.

Using my sample data

firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .startAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

returns zero values…

[chrisbianca]

Ok, I don't have any data setup to test this with at the moment.
When I get some time later on, I'll take a look and see if I can figure out what's going on.

[florianbepunkt]

@chrisbianca okay. I throw together a simple test project and upload it if that helps

[chrisbianca]

@florianbepunkt that would be great!

[florianbepunkt]

@chrisbianca @Salakar Okay, here we go… https://github.com/florianbepunkt/fireStackQuery

you can clone the repo, run npm install and run it. I've tested it on ios and it reproduces the issue.

[chrisbianca]

@florianbepunkt @Salakar

So I've figured out why it's broken in Java... It's passing the startAt and endAt as a String rather than a number. The fix is an awful lot of repetitive code but I can't think of a better way to work around it! Just pushed the fix to the v3 branch and sorted for boolean types too.

Will try and look at iOS now...

[florianbepunkt]

@chrisbianca great! just checked android version with your commit