Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android listenForAuth method to correctly check for user #124

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Fix Android listenForAuth method to correctly check for user #124

merged 1 commit into from
Nov 11, 2016

Conversation

ghuh
Copy link
Contributor

@ghuh ghuh commented Nov 10, 2016

listenForAuth was not correctly checking for a user object so the user object was never populated on the callback.

auser
auser reviewed Nov 10, 2016
View reviewed changes
Copy link
Contributor

@auser auser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I'll check it out

@ghuh
Copy link
Contributor Author

ghuh commented Nov 10, 2016

The old code may have worked in certain scenarios where the user instance variable had already been set. However, it was guaranteed to fail when setting listenForAuth on app startup to see if a user is already logged in.

This new code will work in all scenarios.

@auser auser merged commit c811a3a into fullstackreact:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auser auser auser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghuh @auser