Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firebase cloud messaging #6

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

slycoder
Copy link
Contributor

  • Update the Pods to include FirebaseMessaging
  • Add a ‘configured’ option so that we can get a Firestack object while
    skipping configuration (in case you know that it’s been configured in
    AppDelegate)

* Update the Pods to include FirebaseMessaging
* Add a ‘configured’ option so that we can get a Firestack object while
skipping configuration (in case you know that it’s been configured in
AppDelegate)
@auser
Copy link
Contributor

auser commented Aug 16, 2016

Hey thanks for the pull!

I can't merge this yet as I can't get it to compile for me without throwing an error (I believe, this is initial investigation due to the GIPReachability library checking for a listener). How do you think we can/should provide a listener for the user who is not using the AppDelegate to set up a listener?

I think imagine setting up a listener automatically that emits a JS event by default and allowing the user to set up a JS listener manually. Perhaps you have a better idea?

@slycoder
Copy link
Contributor Author

Lemme try to fiddle with it (xcode is a bear sometimes) and see if it compiles for me; do you have a test harness handy that you're using to build?

@auser
Copy link
Contributor

auser commented Aug 17, 2016

@slycoder cool... yeah, Xcode can be a pain. I just have a sample app... I haven't found a convenient testing method yet beyond use... embarrassing, I know.

@slycoder
Copy link
Contributor Author

Hm, I was able to get it to build out-of-the-box. Just did the following:

react-native init firestack_example

Then installed firebase and this branch of firestack. Here's my package.json:

{
  "name": "firestack_example",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start"
  },
  "dependencies": {
    "firebase": "^3.3.0",
    "react": "15.2.1",
    "react-native": "0.31.0",
    "react-native-firestack": "git+https://github.com/slycoder/react-native-firestack#1ca2a72b37a019ecabd1f6ccae850af17d019b30"
  }
}

Do you know where your build is failing?

@auser
Copy link
Contributor

auser commented Aug 22, 2016

UPDATE: You know what, nevermind. This works for me from your branch. I'll check it again with the latest work this evening.

@auser
Copy link
Contributor

auser commented Aug 23, 2016

Yep. This works locally for me. I'll merge it in! Thanks for the contribution!

Do you have an idea on what the JS API should look like?

@auser auser merged commit 68ea872 into fullstackreact:master Aug 23, 2016
@slycoder
Copy link
Contributor Author

I think react-native-fcm actually has as good bead on this, hopefully we can figure out a way to integrate some of those ideas here and have a one-stop shop for this stuff.

BlooJeans pushed a commit to devshackio/react-native-firestack that referenced this pull request Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants