-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firebase cloud messaging #6
Conversation
* Update the Pods to include FirebaseMessaging * Add a ‘configured’ option so that we can get a Firestack object while skipping configuration (in case you know that it’s been configured in AppDelegate)
Hey thanks for the pull! I can't merge this yet as I can't get it to compile for me without throwing an error (I believe, this is initial investigation due to the GIPReachability library checking for a listener). How do you think we can/should provide a listener for the user who is not using the I think imagine setting up a listener automatically that emits a JS event by default and allowing the user to set up a JS listener manually. Perhaps you have a better idea? |
Lemme try to fiddle with it (xcode is a bear sometimes) and see if it compiles for me; do you have a test harness handy that you're using to build? |
@slycoder cool... yeah, Xcode can be a pain. I just have a sample app... I haven't found a convenient testing method yet beyond use... embarrassing, I know. |
Hm, I was able to get it to build out-of-the-box. Just did the following: react-native init firestack_example Then installed firebase and this branch of firestack. Here's my package.json:
Do you know where your build is failing? |
UPDATE: You know what, nevermind. This works for me from your branch. I'll check it again with the latest work this evening. |
Yep. This works locally for me. I'll merge it in! Thanks for the contribution! Do you have an idea on what the JS API should look like? |
I think react-native-fcm actually has as good bead on this, hopefully we can figure out a way to integrate some of those ideas here and have a one-stop shop for this stuff. |
Fix syntax error in authListener
skipping configuration (in case you know that it’s been configured in
AppDelegate)