Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch safariViewController on main queue #207

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Dispatch safariViewController on main queue #207

merged 2 commits into from
Jul 29, 2018

Commits on May 8, 2018

  1. Dispatch safariViewController on main queue 

    The safariViewController dispatch was occuring on another thread.
This sometimes caused app crashes when the view was presented,
in particular if the keyboard had been presented via a TextInput or
other component. The resulting crash complained about
_cachedSystemAnimationFence and the main thread. This has been with
other React Native apps that load a viewController.

Dispatching to present the viewController on the main thread fixes this
issue.
    @stonehippo
    stonehippo committed May 8, 2018
    Configuration menu
    Copy the full SHA
    aa31836 View commit details
    Browse the repository at this point in the history

  2. Fix build issue

    @stonehippo
    stonehippo committed May 8, 2018
    Configuration menu
    Copy the full SHA
    b311024 View commit details
    Browse the repository at this point in the history