Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go 1.18 support; set Dockerfile to go 1.18 #325

Merged
merged 3 commits into from
Jul 25, 2022
+18 −25
Merged

Add go 1.18 support; set Dockerfile to go 1.18 #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2f3652
add go1.18 support; set go1.18 in Dockerfile
dragonsinth Jul 20, 2022
8daa63a
use new circle images
dragonsinth Jul 20, 2022
4c76b55
cleanup circle ci, don't use cache
dragonsinth Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,46 +5,38 @@ shared_configs:
name: Run tests
command: |
make deps test

full_job_steps: &full_job_steps
- checkout
- run:
name: Run tests
command: |
make ci

# Use the latest 2.1 version of CircleCI pipeline process engine. See: https://circleci.com/docs/2.0/configuration-reference
version: 2.1
jobs:
build-1-15:
working_directory: ~/repo
docker:
- image: circleci/golang:1.15
- image: cimg/go:1.15
steps: *simple_job_steps

build-1-16:
working_directory: ~/repo
docker:
- image: circleci/golang:1.16
steps:
- checkout
- restore_cache:
keys:
- go-mod-v4-{{ checksum "go.sum" }}
- run:
name: Install Dependencies
command: go mod download
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to run this command anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, the necessary modules will be downloaded when it tries to build. This was broken out before in order to try to populate Go's module cache and then persist it to Circle's cache. I found this to be a net loss; restoring the cache could take several minutes, while the non-cached versions would completely in like 1 minute.

- save_cache:
key: go-mod-v4-{{ checksum "go.sum" }}
paths:
- "/go/pkg/mod"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on watching builds go through, it seems like trying to cache is more trouble than it's worth.

- run:
name: Run tests
command: |
#mkdir -p /tmp/test-reports
#gotestsum --junitfile /tmp/test-reports/unit-tests.xml
make ci
#- store_test_results:
# path: /tmp/test-reports
- image: cimg/go:1.16
steps: *full_job_steps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why only build-1-16 is using full_job_steps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't; I get the idea of only running the full deal on 1/4 steps, but I'm not sure why Go 1.16 was specifically chosen for this.


build-1-17:
working_directory: ~/repo
docker:
- image: circleci/golang:1.17
- image: cimg/go:1.17
steps: *simple_job_steps

build-1-18:
working_directory: ~/repo
docker:
- image: cimg/go:1.18
steps: *simple_job_steps

workflows:
Expand All @@ -53,3 +45,4 @@ workflows:
- build-1-15
- build-1-16
- build-1-17
- build-1-18
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.15-alpine as builder
FROM golang:1.18-alpine as builder
MAINTAINER FullStory Engineering

# create non-privileged group and user
Expand Down