Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rustify lempel_ziv_complexity #107

Merged
merged 7 commits into from
Nov 1, 2023
Merged

feat: Rustify lempel_ziv_complexity #107

merged 7 commits into from
Nov 1, 2023

Conversation

abstractqqq
Copy link
Collaborator

@abstractqqq abstractqqq commented Oct 27, 2023

Implemented the first Polars Plugin: lempel_ziv_complexity. We now have both eager and lazy version for this feature too ( and is super fast )

How to test:

  1. maturin develop --release
  2. If package is not install in local environment, do pip install .
  3. pytest tests/test_tsfresh (there is a test on lempel_ziv_complexity, which is the expr plugin implemented in this PR)

Definitely need to review this process and try to improve this process. @topher-lo

@abstractqqq abstractqqq requested a review from topher-lo October 27, 2023 04:13
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 8:44pm

@abstractqqq abstractqqq added the enhancement New feature or request label Oct 27, 2023
@ritchie46
Copy link

@messense can you shed some light on how we can ensure this best?

I thought maturin build always put the shared library in the same folder as the python code?

@ritchie46
Copy link

@abstractqqq I expect you have your file names incorrect.

It is important that the name in the Cargo.toml, the python package and the rust lib match.

@abstractqqq
Copy link
Collaborator Author

@abstractqqq I expect you have your file names incorrect.

It is important that the name in the Cargo.toml, the python package and the rust lib match.

I think the file isn't generated in the right location on windows... I did the same thing and got it working on Linux. It is working now

@messense
Copy link

messense commented Oct 31, 2023

I thought maturin build always put the shared library in the same folder as the python code?

By default yes, but it can be changed via [tool.maturin] module-name in pyproject.toml

https://github.com/neocortexdb/functime/blob/14fa0813c524f23032947a30862551fd2fb6c957/pyproject.toml#L131

In this case it's named _functime_rust

@topher-lo
Copy link
Contributor

@abstractqqq Apart from the conflicts (nothing too serious), I think this is good to go.

@topher-lo topher-lo changed the title added first plugin feat: Rustify lempel_ziv_complexity Nov 1, 2023
@topher-lo topher-lo merged commit c5a87f6 into main Nov 1, 2023
5 checks passed
@topher-lo topher-lo deleted the feat/impl_plugins branch November 1, 2023 17:41
topher-lo pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants