Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks: formatting with ruff, format pyproject.toml #108

Merged
merged 14 commits into from
Oct 29, 2023
Merged

Update pre-commit hooks: formatting with ruff, format pyproject.toml #108

merged 14 commits into from
Oct 29, 2023

Conversation

baggiponte
Copy link
Collaborator

Configure ruff format and format the whole codebase.

@baggiponte baggiponte requested a review from topher-lo October 28, 2023 10:24
@vercel
Copy link

vercel bot commented Oct 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 10:40am

@baggiponte baggiponte self-assigned this Oct 28, 2023
@baggiponte baggiponte added cicd Continuous integration / Continuous deployment build Build system and dependencies labels Oct 28, 2023
@baggiponte baggiponte mentioned this pull request Oct 28, 2023
Merged
@baggiponte baggiponte changed the title Build/ruff Update pre-commit hooks: formatting with ruff, format pyproject.toml Oct 28, 2023
@baggiponte
Copy link
Collaborator Author

Ciao @topher-lo, I just merged main in this branch. This is technically ready for review and should be fine. However, there are two more pre-commit hooks I'd like to add, if you agree.

  1. To avoid incurring in another issue like Restore M4 daily train data with git lfs #110, we should add pre-commit check-added-large-files and potentially scope it to the data/ dir alone. This commit ignores by default git lfs data but will prevent someone who hasn't configured git lfs to upload a dataset by mistake.
  2. Locally ruff finds issues in the benchmarking notebook. If I fix the error, the notebook metadata changes and versioning those is a PITA. Do we need to version the contents of notebooks too? Otherwise I have the solution: nbstripout's pre-commit hook. If you agree I can add that to the pre-commit hook list.

Also

@topher-lo topher-lo merged commit 14fa081 into functime-org:main Oct 29, 2023
5 checks passed
@baggiponte baggiponte deleted the build/ruff branch October 29, 2023 14:56
topher-lo pushed a commit that referenced this pull request Dec 19, 2023
@baggiponte
chore: Setup and run Ruff as main formatter (#108)
4c517de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo topher-lo approved these changes

Assignees

@baggiponte baggiponte

Labels
build Build system and dependencies cicd Continuous integration / Continuous deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baggiponte @topher-lo