Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tsfresh abs features and change quantiles #66

Merged
merged 15 commits into from
Oct 11, 2023
Merged

fix: tsfresh abs features and change quantiles #66

merged 15 commits into from
Oct 11, 2023

Conversation

MathieuCayssol
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Oct 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 4:06am

@MathieuCayssol MathieuCayssol mentioned this pull request Oct 9, 2023
Merged
abstractqqq
abstractqqq requested changes Oct 9, 2023
View reviewed changes
functime/feature_extraction/tsfresh.py Outdated Show resolved Hide resolved
functime/feature_extraction/tsfresh.py Show resolved Hide resolved
functime/feature_extraction/tsfresh.py Outdated Show resolved Hide resolved
functime/feature_extraction/tsfresh.py Show resolved Hide resolved
functime/feature_extraction/tsfresh.py Outdated Show resolved Hide resolved
@topher-lo topher-lo changed the title Feat/unittests feat: unittests Oct 9, 2023
@topher-lo topher-lo changed the title feat: unittests test: Add missing tsfresh unit tests Oct 9, 2023
@topher-lo topher-lo changed the title test: Add missing tsfresh unit tests fix: tsfresh abs features and change quantiles Oct 9, 2023
@topher-lo topher-lo marked this pull request as ready for review October 9, 2023 21:32
topher-lo
topher-lo reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @MathieuCayssol to respond to @abstractqqq

@abstractqqq
Copy link
Collaborator

Waiting for @MathieuCayssol to respond to @abstractqqq

I think the problem is that he didn't pull the changes I made in tsfresh.py...

Everything in unit test looks good. Only the things in tsfresh.py..

@MathieuCayssol
Copy link
Collaborator Author

MathieuCayssol commented Oct 10, 2023 •
edited
Loading

I did pull your changes from the main branch after your merge in main but kept the pure polars changes I've made. I will revert back to your numpy implementation after our alignement. @abstractqqq

@topher-lo topher-lo merged commit a311b21 into main Oct 11, 2023
5 checks passed
@topher-lo topher-lo deleted the feat/unittests branch October 11, 2023 10:39
@topher-lo topher-lo mentioned this pull request Oct 11, 2023
Closed
topher-lo pushed a commit that referenced this pull request Dec 19, 2023
@MathieuCayssol
fix: tsfresh abs features and change quantiles (#66)
db8d2fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo topher-lo left review comments

@abstractqqq abstractqqq abstractqqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathieuCayssol @abstractqqq @topher-lo