Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: Clean up array types #23

Closed
2 tasks done
elycruz opened this issue Mar 14, 2020 · 1 comment
Closed
2 tasks done

next: Clean up array types #23

elycruz opened this issue Mar 14, 2020 · 1 comment
Labels
enhancement
Milestone
List methods to t...

Comments

@elycruz
Copy link
Member

elycruz commented Mar 14, 2020 •
edited
Loading

Differently named types for array and string operations are littered through out and should be consolidated and cleaned up (cleaned-up in the cases where they are defining auxillary types that we've already created (see src/jsPlatform/array/types etc.).

  • fjl
    • - Move 'src/list/types' PredForSlice and PredForIndexable to 'src/types/data'
    • - Types in 'src/platform/types' should be moved to 'src/types'
@elycruz elycruz added this to the List methods to typescript milestone Mar 14, 2020
elycruz added a commit that referenced this issue Jun 13, 2021
@elycruz
#23 - Progress on cleaning up array types. Changed all '**/types/*.ts…
3906797 
…' references to point to '**/types' (since types will be/may be moved around, as part of this fix makes sense to keep the paths this way going forward to allow for these kind of edits to happen).
elycruz added a commit that referenced this issue Jun 13, 2021
@elycruz
#23 - Consolidated array typings into 'fjl/src/types'.
e7c5a8d
@elycruz elycruz mentioned this issue Jun 13, 2021
Merged
@elycruz
Copy link
Member Author

elycruz commented Jun 13, 2021

Fix merged in pull request:
#49

@elycruz elycruz closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
List methods to typescript
Development

No branches or pull requests
1 participant
@elycruz