Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: Allow infered types #61

Open
3 of 10 tasks
elycruz opened this issue Aug 27, 2022 · 0 comments
Open
3 of 10 tasks

next: Allow infered types #61

elycruz opened this issue Aug 27, 2022 · 0 comments
Assignees
@elycruz

Comments

@elycruz
Copy link
Member

elycruz commented Aug 27, 2022 •
edited
Loading

Typescript has a good inference engine (any - Used when some types are left out etc.) which can infer most type information when using the languages primitives (Array, string, number, etc.). When this is the case , and/or we need union types, we should not restrict types we should allow the inference engine to take over - Lessens the amount of "typings" required, speeds up development, and makes function more versatile (in a restricted sense).

We need to remove typescript "typings" where they're not, absolutely, necessary.

Acceptance Criteria

Remove typings where they aren't required (in):

  • './src/boolean/'
    • Tests.
    • Documentation.
  • './src/list/'
    • Tests.
    • Docmentation.
  • './src/object/'
    • Tests.
    • Documentation.
  • @todo
@elycruz elycruz self-assigned this Aug 27, 2022
elycruz added a commit that referenced this issue Aug 27, 2022
@elycruz
issue-#43,#61 - Re-instated previous 'Slice' struct implementation (t…
152f0ca 
…hough modified to absolutely work for strings, arrays, or objects meeting the requirements - type need fine tweaking to match the intersected types' internals ('concat()', '[index: number]: ...', types etc.).

- Progress on updating existing methods to have 'green' tests.
elycruz added a commit that referenced this issue Aug 27, 2022
@elycruz
issue-#43,#61 - Privatized 'SliceBase' type.
61e810c 
- Updated TypedArray type's 'concat' method declaration.
elycruz added a commit that referenced this issue Aug 27, 2022
@elycruz
issue-#43,#61 - Re-instated 'Slice' type some 'list' methods.
a1e5894 
- Cleaned tests for 'permutations' method.
elycruz added a commit that referenced this issue Aug 27, 2022
@elycruz
issue-#43,#61 - Cleaned up some tests.
45147ba 
- Updated some methods to take 'Slice' type.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#43,#61 - Progress on types (adding Slice type, simplifying imp…
e31d52e 
…lementaitons and types)and updates to tests towards 'green' tests.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#43,#61 - Updated 'Slice' type to include 'string', "and", 'T[]…
56526e6 
…' - Makes type more flexible.

- Updated 'group', 'groupBy', 'intercalate', and 'intersperse' types, to allow 'Slice' type.
- Updated tests for, the above, and 'concatMap'.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#43,#61 - Updated 'cycle' tests.
9f6d60d
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#43,#61 - Updated 'cycle' tests.
8eff8d9 
- All tests green.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Removed some generics in 'object/is' module.
4390ea7 
- Added tests scaffold for 'number/' module.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Removed some generics in 'object/is' module.
22919d7 
- Added tests scaffold for 'number/' module.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Removed unrequired types ('Indexable', 'PredForIndexable'…
38b6bdf 
…, etc.) and their associated types - We have general types that can stand in for these (e.g., 'TernaryPred', etc.).

- data/maybe - Removed unused method import.
- tests/number - Updated empty test suite, so it doesn't fail.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Updated 'Either' type in 'either' module.
ed2494f
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Updated package.json.engines.node version, for all packages.
95b1940 
- Added './.node-version'.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Removed types from 'list/lookup' method.
445e6b3
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Removed types from 'list/lookup' method.
0597064 
- Re-generated package-lock.json.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - fjl/ - Removed instances of 'typeof this' in type declara…
a673d72 
…tions.

- Simplified implementation in 'length' module, to remove cyclic dependency.
- Disabled tsconfig 'declaration' option in default some tsconfig.json files.
-
Added 'global' property to 'output' configs in 'fjl/rollup.config'.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - fjl/ - Removed instances of 'typeof this' in type declara…
7be7d79 
…tions.

- Simplified implementation in 'length' module, to remove cyclic dependency.
- Disabled tsconfig 'declaration' option in default some tsconfig.json files.
- Added 'global' property to 'output' configs in 'fjl/rollup.config'.
elycruz added a commit that referenced this issue Aug 28, 2022
@elycruz
issue-#61 - Updated .github/workflows/monorepo*.yml to contain update…
6b4d32c 
…d node versions.

- Began updating the main README file.
- Separate out methods in 'number/' module to separate files.
Updated readmes in 'platform/', and 'types/'.
elycruz added a commit that referenced this issue Sep 2, 2022
@elycruz
issue-#61 - Updated all 'arity' types to have optional parameters ins…
4b01d84 
…tead of required ones (more ergonomic).

- Renamed 'FunctorMapFn' to 'FunctorMapOp' - so it follows same naming schema as other '*Op' methods.  - Added types to 'FunctorMapOp'.
- Simplified 'maybe' method implementation.
- Renamed some generics.
elycruz added a commit that referenced this issue Sep 2, 2022
@elycruz
issue-#61 - Removed 'demo' workflow file.
6b21799
elycruz added a commit that referenced this issue Sep 2, 2022
@elycruz
issue-#61 - Removed 'demo' workflow file.
337b469 
- Removed 'packages/fjl/CHANGELOG' file.
elycruz added a commit that referenced this issue Sep 2, 2022
@elycruz
issue-#61 - Updated fjl-inputfilter tests.
f58e3d9 
- Updated 'runIoFilters', and 'runFilters' method types, and implementations - 'type' typo existed there impeding tests from passing.
- Updated 'Monad', and 'Maybe' tests.
elycruz added a commit that referenced this issue Sep 2, 2022
@elycruz
issue-#61 - Added tests for 'bind'/'' methods.
37c7c2a
elycruz added a commit that referenced this issue Sep 12, 2022
@elycruz
issue-#61 - Updated 'UnaryPred<T>' type to take an optional 'x', inst…
8ad5893 
…ead of an 'required x'.
elycruz added a commit that referenced this issue Sep 13, 2022
@elycruz
issue-#61 - Updated prepare script, package.json.
8d680eb 
- Removed unrequired todos file.
elycruz added a commit that referenced this issue Sep 13, 2022
@elycruz
Merge branch 'issue-#61-types_simplification' of github.com:functiona…
6e34ef6 
…l-jslib/fjl into issue-#61-types_simplification
elycruz added a commit that referenced this issue Sep 18, 2022
@elycruz
issue-#61 - Added .node-version, and .npmrc, files.
c2f4a55 
- Added 'fjl-validator-recaptcha' to workspace, and test configs.
elycruz added a commit that referenced this issue Sep 18, 2022
@elycruz
issue-#61 - Ran 'eslint --fix ./'.
99be510 
- Renamed '.eslintrc' to '.eslintrc.json'.
- Fixed eslint issue in sources.
elycruz added a commit that referenced this issue Nov 2, 2022
@elycruz
Merge pull request #62 from functional-jslib/issue-#61-types_simplifi…
1e74609 
…cation

Issue #61 types simplification
elycruz added a commit that referenced this issue Dec 13, 2022
@elycruz
Merge branch 'issue-#61-types_simplification' of github.com:functiona…
211490d 
…l-jslib/fjl into monorepo
elycruz added a commit that referenced this issue Dec 13, 2022
@elycruz
issue-#57, issue-#61 - Updated 'at' method to ecmascript version of m…
e06f0a8 
…ethod.
@elycruz elycruz mentioned this issue Dec 30, 2023
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elycruz