Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Methods that return booleans but take more than one arg, should not have their members flipped #80

Closed
4 tasks done
Tracked by #57
elycruz opened this issue Dec 30, 2023 · 0 comments · Fixed by #85
Closed
4 tasks done
Tracked by #57
Labels
enhancement groomed Ticket has been groomed for development.

Comments

@elycruz
Copy link
Member

elycruz commented Dec 30, 2023

In the functional world its a convention to receive the returning type last; E.g., methods that create new versions of the last received value, etc.

We have some methods that are defined using the above convention however for methods that return booleans (in some places).

We should keep method args order to the non-functional convention when we're returning booleans (as this is more straight forward).

Acceptance Criteria

  • List methods that need updating (to use later in release changelog).
    • instanceOf
    • hasOwnProperty
  • Update methods that need updating.
@elycruz elycruz added enhancement groomed Ticket has been groomed for development. labels Dec 30, 2023
@elycruz elycruz mentioned this issue Dec 30, 2023
41 tasks
elycruz added a commit that referenced this issue Feb 9, 2024
…ated some doc blocks, and removed some unrequired imports..
elycruz added a commit that referenced this issue Feb 9, 2024
… updated some doc blocks, and removed some unrequired imports..
elycruz added a commit that referenced this issue Feb 9, 2024
…ated 'isset' method, and reversed params for 'hasOwnProperty' method.
elycruz added a commit that referenced this issue Feb 9, 2024
…ated 'isset' method, and reversed params for 'hasOwnProperty' method.
elycruz added a commit that referenced this issue Feb 9, 2024
…placed use of '(\!)isset' with 'notNullish', and 'isNullish', respectively.
elycruz added a commit that referenced this issue Feb 9, 2024
…d 'isInstanceOf' to 'instanceOfSome', and replaced use of '(\!)isset' with 'notNullish', and 'isNullish', respectively.
@github-project-automation github-project-automation bot moved this to Done in Fjl v2.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement groomed Ticket has been groomed for development.
Projects
Status: Done
1 participant