Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: take, takeWhile, and similar, methods should also work with generators #87

Closed
5 tasks done
Tracked by #57
elycruz opened this issue Feb 15, 2024 · 0 comments · Fixed by #93
Closed
5 tasks done
Tracked by #57

next: take, takeWhile, and similar, methods should also work with generators #87

elycruz opened this issue Feb 15, 2024 · 0 comments · Fixed by #93
Assignees
@elycruz
Labels
enhancement

Comments

@elycruz
Copy link
Member

elycruz commented Feb 15, 2024 •
edited
Loading

Acceptance Criteria

Update methods to accept Iterable<T> instead of Slice/(string | array) types.

  • take
  • takeWhile*
  • drop
  • dropWhile
  • dropWhileEnd Implementing this for generators isn't possible (in a peformant way) due to generators being direction agnostic.
elycruz added a commit that referenced this issue Feb 16, 2024
@elycruz
issue-#57, #87 - Updated 'take' implementation to allow iterable type…
7f0cf26 
…s (including generators) to be parsed.
elycruz added a commit that referenced this issue Feb 16, 2024
@elycruz
issue-#57, #87 - Updated 'takeWhile' implementation to allow receivin…
f5eaa8a 
…g iterables, and removed 'nullish' checks in 'instanceOf' method.
elycruz added a commit that referenced this issue Feb 16, 2024
@elycruz
issue-#57, #87, #90 - Updated 'takeWhile' implementation to allow rec…
8f890aa 
…eiving iterables, and removed 'nullish' checks in 'instanceOf' method.
@elycruz elycruz mentioned this issue Feb 17, 2024
Open
41 tasks
elycruz added a commit that referenced this issue Feb 25, 2024
@elycruz
issue-#57, #87 - Updated 'drop' method to support 'Iterable<T>', and …
2740ac1 
…updated some docs.
elycruz added a commit that referenced this issue Feb 26, 2024
@elycruz
issue-#57, #87 - Updated 'drop' types, and dropWhile declaration to a…
313582e 
…llow any iterables to be passed in.
elycruz added a commit that referenced this issue Feb 26, 2024
@elycruz
issue-#57, #87 - Updated 'drop' types, and dropWhile declaration to a…
951ec02 
…llow any iterables to be passed in.

Additionally updated some docs.
@elycruz elycruz self-assigned this Feb 26, 2024
@elycruz elycruz mentioned this issue Feb 26, 2024
Merged
elycruz added a commit that referenced this issue Feb 26, 2024
@elycruz
issue-#57, #87 - Added curried version method to tests (for 'take*', …
9a14b9c 
…and 'drop*', methods).
elycruz added a commit that referenced this issue Feb 26, 2024
@elycruz
Merge pull request #93 from functional-jslib/dev
95de89a 
issue-#87 - Updates `take*`, and `drop`/`dropWhile`, methods to accept an `Iterable<T>` instead of custom type
@github-project-automation github-project-automation bot moved this to Done in Fjl v2.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
enhancement
Projects
Fjl v2.0
Status: Done
Milestone
No milestone
1 participant
@elycruz