Issue 30 issue 43 simplify slice usage #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' to 'Indexable<...>'.
…g slice methods to instead match `<T, T2 extends Slice<T>>(...) => {}` instead of `<T>(xs: Slice<T>, ...) => {}` (new approach is more ergonomic and will allow us to only target `Slice` for methods where it makes sense.
…hods. Updated 'Slice' type to also include 'SliceInterface' type in it's type sum.
- Updated 'Slice' type to be either the 'Slice' interface or an array of any - Appeases most requirements, though the requirement for allowing strings to be Slices is still not appeased.
…unctional-jslib/fjl into issue-30-issue-43-simplify_slice_usage
…ings in tests based on latest updates to 'types'.
…only: Curry\d, CurryOf\d, CurriedOf\d - Easier to reason about/grok. Updated curry* implementations so they generate better return values - previously the return values were vague and always had to be typed - now return types are good enough that they don't need to be 'typed', in general cases.
…laced 'curried' implementations with idiomatic versions.
… for true curry minimal types to be used throughout code base.
Updated fjl-inputfilter test-input '#runValidators' tests.
… proof of concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.